Feature: Added api for getting/setting the kv_cache #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api provides access methods for retrieving the current memory buffer for the kv_cache and its token number. It also contains a method for setting the kv_cache from a memory buffer. This makes it possible to load/save history - maybe support --cache-prompt paramater as well?
|
Example app using the new api to load the state is able to answer with previous knowledge from the saved prompt (uses the chat example):
|
prusnak
requested changes
Apr 1, 2023
Add review comments Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Added review comments Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Added review comments Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Review Comments Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
|
Thanks for the comments, @prusnak - appreciate it. |
prusnak
approved these changes
Apr 2, 2023
This was referenced Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a simple extension to the C-API for getting/setting the kv_cache so that an app can save the state of the kv_cache after providing a prompt and load this next time the app starts to avoid having to evaluate the prompt on startup.
The api provides access methods for retrieving the current memory buffer for the kv_cache and its token number. It also contains a method for setting the kv_cache from a memory buffer and a token count.
I did not start implementing the
--cache-promptargument since it is a bit more involved - we need to save some more state like the last_n_tokens and n_past parameter. We'd also need to hash the prompt, check if a prompt file existed etc.Implements foundation for #64